Docs: Added Typography and Icons to Foundation section - #254
Conversation
8241328 to
c617eb1
Compare
d3a2843 to
54e3662
Compare
| </td> | ||
| </tr> | ||
| <tr> | ||
| <td>Download</td> |
There was a problem hiding this comment.
Would these icons be used also for save/load? If so worth adding to the table as they are common in GDA at least
There was a problem hiding this comment.
I wanted to show examples rather than showing a full list. I was also avoiding save on purpose as I find the disk anachronistic and not sure about it... (reasoning: modern software saves automatically, download shows differently, save to cloud also different, so it loses its meaning)
| */ | ||
| declare module "@mui/material/styles" { | ||
| interface TypographyVariants { | ||
| h1Display: React.CSSProperties; |
There was a problem hiding this comment.
Could we have our own Typography storybook stories to demonstrate each variant along with a short note on how/when to use each? Or make the variants available in the existing MUI stories
There was a problem hiding this comment.
Yes, that is a good point - should I add one to this PR? or create a new one?
Added: 2. typography 3. Icons + - Added icons pack to show icons - Updated typography to align with #222 - Icons is standalone
54e3662 to
e4c9212
Compare
|
@douglaswinter Updated some of the wording around |
2 participants
This branch is dependent on #222 and related to future #209 (but not required)